Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T295716

Having a Z2K1 value of Z0 raises "internal server error" in running tester
Closed, DeclinedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Create a new (working) tester in the UI
  • Enable "expert mode"
  • cut and paste the JSON to a file in function-schemata/data/definitions WITHOUT setting the Z2K1 (identity) value, it should default to Z0.
  • run the php maintenance/update.php script to add the new tester

What happens?:

  • the new ZObject seems to display correctly in the UI, but under the test section shows an error:

Test results for ( )
Test status: FAIL
Failure reason: Error: Internal Server Error
Duration: 0 ms

What should have happened instead?:
I can see why an incorrect identify value might cause trouble, but the error message should probably be more informative!

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

ArthurPSmith created this task.Nov 15 2021, 6:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2021, 6:51 PM
cmassaro added a subscriber: gengh.Nov 15 2021, 10:24 PM

I assume this is because of validation. We constrain the values of ZIDs to Z<integer g.t. 0>.

We should probably special-case this for places where Z0 is allowed. I imagine there are places other than Z2K1 where that holds, but I don't know what they are. Maybe @gengh knows?

cmassaro added a comment.Nov 15 2021, 10:27 PM

Just to make this more concrete: in function-schemata, under data/NORMAL/Z9.yaml (line 16), you can see the regex that describes valid reference values. We try to turn Z2K1 into a reference at some point, and we're probably failing a validation check.

DVrandecic closed this task as Declined.Nov 17 2021, 5:31 PM
DVrandecic subscribed.

The Z0 would not work in this place. You have to replace it with the actual ZID (i.e. the one in the file name). Update isn't (and probably shouldn't?) be smart enough to capture that.

I am closing this as declined, in order to keep the update script simpler (and also, a bit faster).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits