Deferred update 'MWCallableUpdate_SpecialContentTranslation->enableCXBetaFeature' failed to run.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	KartikMistry
	May 12 2020, 7:29 AM

Description

Error origin: CX Logstash/Kibana dashboard.
User impact: CX Beta feature is not enabled in the target wiki.
Frequency: 6 times in last 7 days.

Deferred update 'MWCallableUpdate_SpecialContentTranslation->enableCXBetaFeature' failed to run.

Next example error is:

[XrgqQgpAEKIAAuLWnfYAAAEY] /wiki/Special:ContentTranslation?title=Special:ContentTranslation&campaign=contributionsmenu&to=pl&page=Jesuit+Forum+for+Social+Faith+and+Justice&from=en&targettitle=Jesuit+Forum+for+Social+Faith+and+Justice   MWException from line 3979 of /srv/mediawiki/php-1.35.0-wmf.30/includes/user/User.php: CAS update failed on user_touched. The version of the user to be saved is older than the current version.

QA plan

Affected projects: All Wikipedias
Pre-deployment testing: skip
Post-deployment testing: monitor Logstash for this error for 7 days after deployment to confirm error is fully gone or extremely infrequent

Outcome

Fixed an issue where Content Translation beta feature did not always get enabled automatically when starting a new translation

Details

	Subject	Repo	Branch	Lines +/-
	Try to avoid errors in enableCXBetaFeature	mediawiki/extensions/ContentTranslation	master	+8 -4

Customize query in gerrit

Event Timeline

KartikMistry created this task.May 12 2020, 7:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2020, 7:29 AM

The code https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/4b083bde65d4b87477fe4381045c911759d58785/specials/SpecialContentTranslation.php#38 should use User::getInstanceForUpdate.

Change 595890 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Try to avoid errors in enableCXBetaFeature

https://gerrit.wikimedia.org/r/595890

gerritbot added a project: Patch-For-Review.May 12 2020, 9:34 AM

Nikerabbit claimed this task.May 12 2020, 9:36 AM

Nikerabbit added a project: Language-Team (Language-2020-Focus-Sprint).

Nikerabbit triaged this task as High priority.May 12 2020, 11:07 AM

Nikerabbit updated the task description. (Show Details)

Nikerabbit moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.May 13 2020, 8:01 AM

Change 595890 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Try to avoid errors in enableCXBetaFeature

https://gerrit.wikimedia.org/r/595890

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 13 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 13 2020, 10:11 AM

Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.May 14 2020, 10:39 AM

Nikerabbit moved this task from In Review to Needs QA on the Language-Team (Language-2020-Focus-Sprint) board.

Nikerabbit updated the task description. (Show Details)May 28 2020, 11:44 AM

Is this the right way to check on logstash?
https://logstash.wikimedia.org/goto/f60ac80180cb47543e15fe821e083bb1

• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2020-Focus-Sprint) board.Jun 10 2020, 5:52 AM

Yes, if you look at past 30 days for that query (takes a long time to load!), you can see last such error was on May 28th on 1.35.0.wmf.32. This looks like a solid evidence to me that the bug has been fixed.

Nikerabbit closed this task as Resolved.Jun 10 2020, 7:54 AM

Nikerabbit moved this task from Pending input for QA to Done on the Language-Team (Language-2020-Focus-Sprint) board.