Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T226144

Fix flaky Selenium test: Rollback without confirmation should perform rollback via GET request without asking the user to confirm
Closed, InvalidPublic
Actions

Description

See https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php72-docker/953/consoleFull for patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/517701#message-02cba8cf6012362e4ded279c79da2a4c98744f94

17:19:31 1) Rollback without confirmation should perform rollback via GET request without asking the user to confirm:
17:19:31 Expected rollback page to appear.
17:19:31 running chrome
17:19:31 Error: Expected rollback page to appear.
17:19:31     at elementIdText("0.9789767140534527-1") - getText.js:35:50

Screenshot from the failure:

image.png (1×1 px, 497 KB)

Video:

Rollback-without-confirmation-should-perform-rollback-via-GET-request-without-asking-the-user-to-confirm.mp4200 KBDownload

Details

SubjectRepoBranchLines +/-
Disable flaky Selenium testmediawiki/coremaster+1 -1
Disable flaky Selenium testmediawiki/coreREL1_34+1 -1
Disable flaky Selenium testmediawiki/corewmf/1.34.0-wmf.10+1 -1
Disable flaky Selenium testmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Jun 20 2019, 1:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2019, 1:43 AM
gerritbot added a comment.Jun 20 2019, 1:44 AM

Change 517958 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/517958

gerritbot added a project: Patch-For-Review.Jun 20 2019, 1:44 AM
kostajh updated the task description. (Show Details)Jun 20 2019, 2:15 AM
gerritbot added a comment.Jun 20 2019, 3:02 AM

Change 517961 had a related patch set uploaded (by Krinkle; owner: Kosta Harlan):
[mediawiki/core@wmf/1.34.0-wmf.10] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/517961

gerritbot added a comment.Jun 20 2019, 3:12 AM

Change 517958 merged by jenkins-bot:
[mediawiki/core@master] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/517958

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 20 2019, 4:00 AM
gerritbot added a comment.Jun 20 2019, 3:08 PM

Change 517961 merged by jenkins-bot:
[mediawiki/core@wmf/1.34.0-wmf.10] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/517961

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 3:10 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 20 2019, 4:00 PM
Tgr subscribed.Jun 22 2019, 7:21 PM

The POST equivalent seems flaky as well:
https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-postgres-php72-docker/1011/console

21:10:35 1) Rollback without confirmation should perform rollback via POST request without asking the user to confirm:
21:10:35 Expected rollback page to appear.
21:10:35 running chrome
21:10:35 Error: Expected rollback page to appear.
21:10:35     at elementIdText("0.1626589557410456-1") - getText.js:35:50

(patch is a no-op)

gerritbot added a comment.Oct 8 2019, 8:21 PM

Change 541618 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/541618

gerritbot added a project: Patch-For-Review.Oct 8 2019, 8:21 PM
Krinkle edited projects, added Wikimedia-production-error (ARCHIVED -- Shared Build Failure); removed Browser-Tests.Oct 8 2019, 8:45 PM
Krinkle removed a project: Continuous-Integration-Infrastructure.
Krinkle moved this task from Untriaged to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.
Krinkle mentioned this in T220479: Improve rollback confirmation selenium tests.
gerritbot added a comment.Oct 8 2019, 8:59 PM

Change 541633 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_34] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/541633

gerritbot added a comment.Oct 8 2019, 9:05 PM

Change 541618 merged by jenkins-bot:
[mediawiki/core@master] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/541618

gerritbot added a comment.Oct 8 2019, 9:11 PM

Change 541633 merged by jenkins-bot:
[mediawiki/core@REL1_34] Disable flaky Selenium test

https://gerrit.wikimedia.org/r/541633

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2019, 9:11 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Oct 8 2019, 10:00 PM
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 18 2020, 10:54 PM
Krinkle removed projects: ci-test-error (WMF-deployed Build Failure), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes.Apr 19 2020, 5:37 PM
thiemowmde added projects: WMDE-TechWish-Maintenance, Browser-Tests.Jan 10 2022, 5:22 PM
WMDE-Fisch closed this task as Invalid.EditedJan 26 2022, 2:08 PM
WMDE-Fisch subscribed.

Currently browser tests for rollback confirmation got disabled and removed due to flackyness. It might make sense to re-add at least one browser tests for that functionality in the future. This currently de-prioritized by WMDE.

See T300141: Add basic browser test for rollback confirmation

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits