Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T225099

Use the real datatype for a selected property (in UW) instead of hardcoding wikibase-entityid
Closed, ResolvedPublic
Actions

Description

We have this:

The datavalue datatype is currently hardcoded to wikibase-entityid when adding new properties in UploadWizard.
We need that to be the actual datatype.
See: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/513631/2/resources/metadata/uw.MetadataContent.js#50

We want this:

The search results show the datatype (e.g. wikibase-item), but we need to map that to the datavalue datatype (wikibase-entityid).
This is already done in MediaInfo, in PHP. Useless for UploadWizard, but it's a good place to go look for how it can be done.

Details

SubjectRepoBranchLines +/-
Use the wikibase wbDataTypes variable to map wikibase-item to wikibase-entityidmediawiki/extensions/WikibaseMediaInfomaster+12 -17
Make sure the js variable wbDataTypes is available site-widemediawiki/extensions/WikibaseMediaInfomaster+1 -0
Use the wikibase wbDataTypes variable to map wikibase-item to wikibase-entityidmediawiki/extensions/UploadWizardmaster+3 -3
Add target to wbDataTypes config varmediawiki/extensions/Wikibasemaster+1 -0
Customize query in gerrit

Event Timeline

matthiasmullie created this task.Jun 5 2019, 2:29 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptJun 5 2019, 2:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matthiasmullie added a comment.Jun 6 2019, 7:52 AM

It looks like mw.config.get( 'wbDataTypes' ) already holds this map!
wbDataTypes won't exist on Special:UploadWizard, but we should probably let WikibaseMediaInfo expose a similar (or the exact same) map, in the same way it already does wbmiProperties (and a few others) so that they're always available, even for UploadWizard.

matthiasmullie added a project: SDC-Statements (Other-statements-running).Jun 6 2019, 9:46 AM
Cparle claimed this task.Jun 11 2019, 3:38 PM
Cparle moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.
gerritbot added a comment.Jun 11 2019, 4:57 PM

Change 516521 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Make sure the js variable wbDataTypes is available site-wide

https://gerrit.wikimedia.org/r/516521

gerritbot added a project: Patch-For-Review.Jun 11 2019, 4:57 PM

Change 516522 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/UploadWizard@master] Use the wikibase wbDataTypes variable to map wikibase-item to wikibase-entityid

https://gerrit.wikimedia.org/r/516522

Cparle moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.Jun 12 2019, 8:34 AM
gerritbot added a comment.Jun 12 2019, 11:07 AM

Change 516609 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/Wikibase@master] Add target to wbDataTypes config var

https://gerrit.wikimedia.org/r/516609

gerritbot added a comment.Jun 18 2019, 10:26 AM

Change 516609 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add target to wbDataTypes config var

https://gerrit.wikimedia.org/r/516609

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 18 2019, 1:00 PM
gerritbot added a comment.Jun 19 2019, 12:56 PM

Change 517847 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Use the wikibase wbDataTypes variable to map wikibase-item to wikibase-entityid

https://gerrit.wikimedia.org/r/517847

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Jun 19 2019, 2:26 PM
gerritbot added a comment.Jun 19 2019, 2:49 PM

Change 516521 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Make sure the js variable wbDataTypes is available site-wide

https://gerrit.wikimedia.org/r/516521

gerritbot added a comment.Jun 19 2019, 2:49 PM

Change 516522 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use the wikibase wbDataTypes variable to map wikibase-item to wikibase-entityid

https://gerrit.wikimedia.org/r/516522

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.11; 2019-06-26); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 19 2019, 3:00 PM
gerritbot added a comment.Jun 19 2019, 3:41 PM

Change 517847 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use the wikibase wbDataTypes variable to map wikibase-item to wikibase-entityid

https://gerrit.wikimedia.org/r/517847

Maintenance_bot removed a project: Patch-For-Review.Jun 19 2019, 4:10 PM
Cparle closed this task as Resolved.Jul 4 2019, 12:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits