Nothing Special   »   [go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T97093

Parsoid should mark interwiki links as such
Closed, ResolvedPublic
Actions

Description

Right now there is no distinction between external links and interwiki links, except in data-parsoid (which is private). This makes it difficult for Flow (and other read HTML users) to style interwiki links correctly.

Details

SubjectRepoBranchLines +/-
Interwiki links are a type of external linkmediawiki/extensions/VisualEditormaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Catrope created this task.Apr 23 2015, 11:59 PM
• Catrope raised the priority of this task from to Needs Triage.
• Catrope updated the task description. (Show Details)
• Catrope added projects: Parsoid, Parsoid-DOM.
• Catrope subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 11:59 PM
• Catrope mentioned this in T96855: A15. Flow rendering doesn't render external links correctly.Apr 23 2015, 11:59 PM
• Catrope mentioned this in T97552: Flow renders interwiki links as external links.Apr 29 2015, 5:59 PM
Quiddity awarded a token.Jun 5 2015, 6:03 PM
Arlolra triaged this task as Medium priority.Jul 20 2015, 5:28 PM
Arlolra subscribed.

Related to T100856

Josve05a subscribed.Aug 7 2015, 4:06 PM
This comment was removed by Josve05a.
Josve05a raised the priority of this task from Medium to High.Aug 7 2015, 4:07 PM
Josve05a lowered the priority of this task from High to Medium.
Arlolra mentioned this in T150112: Internal links pointing to interwikis are not encoded at all.Dec 7 2016, 11:35 PM
ssastry moved this task from Needs Triage to Link syntax (links & media) on the Parsoid board.Sep 18 2017, 5:29 PM
ssastry merged a task: T103636: Don't display interwiki links with external icon in VE.
ssastry added subscribers: • Deskana, ssastry, MusikAnimal and 11 others.
ssastry added a comment.Sep 18 2017, 5:34 PM

This was removed as part of T55432: Typeof cleanup and smart serialization of new language and interwiki links. With ISBN, RFC, etc links, it is possible for clients to figure this out, but this is far more complex for interwiki links. So, we should consider adding this back since this affects HTML clients that inspect Parsoid HTML (for semantics or for styling in UIs).

cscott subscribed.Sep 19 2017, 4:51 PM

Note:

In T97552#1518403, @Josve05a wrote:

This also causes [[:en:WP:Flow#Design FAQ]] -> https://en.wikipedia.org/wiki/Wikipedia:Flow#Design%20FAQ meaing that section links with spaces in them breaks. This is a huge...no-no.

the HTML5 ID stuff affects this too. I believe the default WMF config is to use legacy section IDs for interwiki links where we're not positive the other wiki is using new-style IDs yet. Parsoid doesn't make this distinction...

cscott added a subtask: T97552: Flow renders interwiki links as external links.Sep 19 2017, 5:11 PM
Krinkle unsubscribed.Sep 19 2017, 8:36 PM
ssastry assigned this task to • Sbailey.Oct 10 2017, 5:28 PM
ssastry moved this task from Link syntax (links & media) to Next Up on the Parsoid board.
gerritbot subscribed.Nov 28 2017, 7:43 PM

Change 393832 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] WIP T97093 Interlink/WikiLink change

https://gerrit.wikimedia.org/r/393832

gerritbot added a project: Patch-For-Review.Nov 28 2017, 7:43 PM
gerritbot added a comment.Dec 5 2017, 9:17 PM

Change 393832 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T97093: Use mw:WikiLink/InterWiki for interwiki links

https://gerrit.wikimedia.org/r/393832

gerritbot added a comment.Dec 8 2017, 4:01 PM

Change 396069 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@master] Interwiki links are a type of external link

https://gerrit.wikimedia.org/r/396069

Stashbot mentioned this in T114072: <section> tags for MediaWiki sections.Dec 12 2017, 7:57 PM
Stashbot mentioned this in T181226: Don't output section wrappers in body_only mode.
Stashbot mentioned this in T21910: Headings of the form ===+\s+ are not preprocessed correctly..
Stashbot mentioned this in T152540: Migrate to HTML5 section ids.
Stashbot mentioned this in T103714: Fragment encoding in heading anchors and in links differ.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-12-12T19:57:07Z] <arlolra> Updated Parsoid to 741fc5d (T114072, T181226, T21910, T152540, T103714, T97093, T118520, T181229, T182338, T182170, T169006)

Stashbot mentioned this in T118520: Use <figure-inline> instead of <span> for inline figures..Dec 12 2017, 7:57 PM
Stashbot mentioned this in T181229: Content after reference tag in template disappears.
Stashbot mentioned this in T182338: Parsoid: Interwiki links with angle brackets should be invalid.
Stashbot mentioned this in T182170: Create new high-priority linter category for multiple unclosed formatting tags whose effects accumulate.
Stashbot mentioned this in T169006: Correctly redirect in Parsoid /transform/wikitext/to/lint endpoint.
Arlolra closed this task as Resolved.Dec 12 2017, 8:07 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 12 2017, 8:07 PM
gerritbot added a comment.Dec 13 2017, 4:04 PM

Change 396069 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Interwiki links are a type of external link

https://gerrit.wikimedia.org/r/396069

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 13 2017, 5:00 PM
Bencemac added a comment.EditedDec 22 2017, 6:39 PM

Maybe because of the patch, now the external links look like interwiki links (without that little arrow) in 2017 wikitext editor's preview mode.

Example: "első körben itt"
https://www.facebook.com/SwordArtOnlineUSA/

Screenshot-2017-12-22 Szerkesztővita Bencemac szerkesztése – Wikipédia.png (35×1 px, 7 KB)

Edited: @Arlolra Could you check this?

Bencemac reopened this task as Open.Jan 16 2018, 6:05 PM

See my previous comment. Now the problem is that, the external links look like interwiki links.

Kaartic mentioned this in T185083: Consistently style links between read mode VisualEditor modes (internal, inter-wiki and external).Jan 17 2018, 10:16 AM
Bencemac mentioned this in T187571: External links look like interwiki links in preview.Feb 16 2018, 5:56 PM
matmarex subscribed.May 8 2019, 10:13 PM
In T97093#3857694, @Bencemac wrote:

Maybe because of the patch, now the external links look like interwiki links (without that little arrow) in 2017 wikitext editor's preview mode.

Looks like that has been resolved in T58756 in February 2018.

matmarex closed this task as Resolved.May 8 2019, 10:13 PM
matmarex closed subtask T97552: Flow renders interwiki links as external links as Resolved.May 8 2019, 10:16 PM
Jdforrester-WMF removed a subtask: T97552: Flow renders interwiki links as external links.May 8 2019, 10:24 PM
Jdforrester-WMF added a parent task: T97552: Flow renders interwiki links as external links.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits