Rationale on why is at T88436#1013289 and subsequent comments.
Instead of cloning mediawiki/vendor, we should run "composer update". If we are testing extensions, we should create a composer.local.json file that recursively includes those extension's composer.json files if they exist (pending patch).
So far:
The Zend PHPUnit jobs are currently running on production slaves...we can't run composer in production so those will need to be moved to labs slaves.
Should we have a separate mediawiki-phpunit-{phpflavor} / mediawiki-phpunit-{phpflavor}-wmf job where one uses composer and the other uses mediawiki/vendor?
Or can we have the job definition automatically vary based on the branch?
The job definition can not vary by branch. This is statically interpreted ahead of time and submitted to Jenkins as job.
If the fetching of mediawiki/vendor and composer-update were in a bash script, it could use the environment variable ZUUL_BRANCH at run-time, however in this case it's probably better to change the mediawiki-phpunit-* jobs to use composer, and add a mediawiki-phpunit-*-vendor job that (in Zuul layout) is configured to only run on wmf branches of mediawiki core and extensions (and as main job for mediawiki-vendor itself).
Change 193555 had a related patch set uploaded (by Legoktm):
Use composer for experimental mediawiki-phpunit-{phpflavor}-composer jobs
Change 193555 merged by jenkins-bot:
Use composer for experimental mediawiki-phpunit-{phpflavor}-composer jobs
Krinkle and I discussed this a few days ago in #wikimedia-releng. We still need to run composer for wmf branches to fetch dependencies like phpunit. So
It may be better/easier to just stick in a composer.local.json that in turn includes the mw/vendor composer.json. That way if we end up with some need to include even more things we can use the composer.local.json to do that.
run "composer update" (twice?). That will also ensure core's dependencies match vendor's.
I think it will take two runs. The first run will install our custom composer merge plugin and then the second run will actually use it to squish the two sets of composer dependencies together. We could probably get rid of the need for a second run by adding composer-merge-plugin to mw/vendor.
Change 214569 had a related patch set uploaded (by Legoktm):
composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)
Change 214569 merged by jenkins-bot:
composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)
This currently does not work, because the jobs using composer right now clone the source to workingspace, but all other jobs that use zuul-cloner use workingspace/src.
Change 232558 had a related patch set uploaded (by JanZerebecki):
[WIP] Change target for clone to src.
Change 232558 abandoned by JanZerebecki:
[WIP] Change target for clone to src.
Reason:
To many changes needed for this way. Used https://gerrit.wikimedia.org/r/#/c/237710/2 instead.
Since https://gerrit.wikimedia.org/r/#/c/237710/2 the experimental jobs for core work but have 2 phpunit errors: https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-composer/13/console
https://gerrit.wikimedia.org/r/#/c/238188/ created generic jobs with qunit and phpunit for use with extensions.
It seems they work, check example run:
https://gerrit.wikimedia.org/r/#/c/208515/5
https://integration.wikimedia.org/ci/job/mwext-testextension-zend-composer/2/console
https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-composer/2/console
https://integration.wikimedia.org/ci/job/mwext-qunit-composer/2/console
Flow seems to have problems: https://integration.wikimedia.org/ci/job/mwext-qunit-composer/3/console
WARN [Chromium 44.0.2403 (Ubuntu 0.0.0)]: Disconnected (1 times), because no message in 60000 ms.
Change 240438 had a related patch set uploaded (by Legoktm):
composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)
Change 240438 merged by jenkins-bot:
composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)
Change 240951 had a related patch set uploaded (by Legoktm):
composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)
Change 240951 merged by jenkins-bot:
composer.json: Downgrade PHPUnit to 3.7.37 (temporarily)
Change 247920 had a related patch set uploaded (by Paladox):
Add new extension-unittests-composer template