You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Riptide should configure threads.max-size as max thread for it thread pool.
Actual Behavior
Riptide takes connections.max-per-route as max thread if connections.max-per-route is greater than threads.max-size.
Possible Fix
Not include connections.max-per-route in deciding what would be max thread when merging defaults. If no max-thread is configured, then it should take default max thread as max thread
Riptide does not respect thread max-size despite being configured
Description
Riptide takes
connections.max-per-route
as max thread ifconnections.max-per-route
is greater thanthreads.max-size
.Expected Behavior
Riptide should configure threads.max-size as max thread for it thread pool.
Actual Behavior
Riptide takes
connections.max-per-route
as max thread ifconnections.max-per-route
is greater thanthreads.max-size
.Possible Fix
Not include
connections.max-per-route
in deciding what would be max thread when merging defaults. If no max-thread is configured, then it should take default max thread as max threadhttps://github.com/zalando/riptide/blob/main/riptide-spring-boot-autoconfigure/src/main/java/org/zalando/riptide/autoconfigure/Defaulting.java#L105
Steps to Reproduce
connections.max-per-route
is greater thanthreads.max-size
Context
Your Environment
The text was updated successfully, but these errors were encountered: