Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crahes when moving the last page down / first page up through context menu #1637

Closed
ethpi opened this issue Nov 29, 2019 · 3 comments · Fixed by #1653
Closed

crahes when moving the last page down / first page up through context menu #1637

ethpi opened this issue Nov 29, 2019 · 3 comments · Fixed by #1653
Assignees
Labels
bug Crash difficulty::easy PR available There is currently an implementation in review that fixes this issue priority::high
Milestone

Comments

@ethpi
Copy link
ethpi commented Nov 29, 2019
  • OS: Kubuntu 18.04 64bit
  • libgtk 3.22.30-1ubuntu4
  • tested with xournalpp 1.0.6-0 201910191646 ubuntu18.04.1 (The menu help / about shows version 1.0.15) and xournalpp 1.1.0+dev

xournalpp crahes, when moving the last page down

Steps to reproduce the behavior:

  1. Open a new journal
  2. Insert a second empty page
  3. Move the second (last) page down

Xournalpp crahes, the window vanishes from the screen.

@Technius
Copy link
Member
Technius commented Dec 2, 2019

Does this only happen when using the context menu, or is there another way to trigger the crash?

@Technius Technius added this to the v1.1.0 milestone Dec 2, 2019
@ethpi
Copy link
Author
ethpi commented Dec 2, 2019

Instead of moving the last page down you can move the first page up, if the document contains at least two pages. It seems, that moving a page beyond the valid page range, causes the crash.

I don't know how to move a page without using the context menu of the thumbnails in the sidebar.

Do you need an error log? Or something like the output of "strace xournalpp"?

By the way: after a few tests I can trigger a crash, by inserting an image in an empty document:

  1. Select the icon for an image.
  2. Touch the page with the pen to set the position of the picture. Instantly xournalpp crashes.

@Technius Technius changed the title crahes when moving the last page down crahes when moving the last page down / first page up through context menu Dec 2, 2019
@Technius
Copy link
Member
Technius commented Dec 2, 2019

Thanks for the info, the bug should be pretty simple to fix (disable the move down option on the last page / move up option on the first page).

This second crash is unrelated; please post another issue with crash logs and input debugging logs attached.

@Technius Technius added the PR available There is currently an implementation in review that fixes this issue label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Crash difficulty::easy PR available There is currently an implementation in review that fixes this issue priority::high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants