[css-grid] Baseline alignment inside the tracks sizing algorithm #9553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 16, 2018
Build PASSEDStarted: 2018-03-19 23:25:59 View more information about this build on: |
1bf32b5
to
386e310
Compare
386e310
to
c2cb4a4
Compare
c2cb4a4
to
a106cf8
Compare
66b8190
to
0c786b2
Compare
0c786b2
to
9d9ad90
Compare
We have identified several cases where the Baseline Alignment accounts for the grid's intrinsic size. Since we depend on the track sizing algorithm to compute the grid's intrinsic size, the only way to handle all these cases is to integrate the baseline alignment logic in the algorithm. Additionally, the CSSWG has identified several cases that can't be solved properly; such cases have in common that they imply cyclic dependencies between the item's and grid area's size. The CSSWG has resolved that these items don't participate in baseline alignment: w3c/csswg-drafts#1365 There are also other related issues with some examples and relevant discussions about this topic: w3c/csswg-drafts#1039 w3c/csswg-drafts#1409 Bug: 704713 Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22 Reviewed-on: https://chromium-review.googlesource.com/923261 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#562406}
9d9ad90
to
3aba9f9
Compare
|
@javifernandez one of the tests seems to be flaky on Travis. Could you take a look?
|
|
I'm admin-merging the PR as it will soon go out of the history window of Chromium's wpt-sync and will deal with the flakiness in Chromium (the test isn't flaky on Firefox). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified several cases where the Baseline Alignment accounts
for the grid's intrinsic size. Since we depend on the track sizing
algorithm to compute the grid's intrinsic size, the only way to handle
all these cases is to integrate the baseline alignment logic in the
algorithm.
Additionally, the CSSWG has identified several cases that can't be
solved properly; such cases have in common that they imply cyclic
dependencies between the item's and grid area's size. The CSSWG has
resolved that these items don't participate in baseline alignment:
w3c/csswg-drafts#1365
There are also other related issues with some examples and relevant
discussions about this topic:
w3c/csswg-drafts#1039
w3c/csswg-drafts#1409
Bug: 704713
Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22
Reviewed-on: https://chromium-review.googlesource.com/923261
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Reviewed-by: Sergio Villar svillar@igalia.com
Cr-Commit-Position: refs/heads/master@{#562406}