-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-align][css-flexbox][css-grid] partial implementations of space-evenly in grid but not flexbox #1167
Comments
The problem is that CSS Alignment spec tries to define the alignment behavior for different layout models I don't think is a good idea not to ship the feature until is implemented in every layout model, which probably will take years. |
Which is why I think it is important that we think through (and document) how we expect this to be released to minimize breakage. |
We can clarify here, but certainly in the two contexts in which the property works, all supported keywords should be equally supported. |
Clarified: 55a77e0 |
@fantasai so if I understand correctly, chrome and safari should either unship @mrego Is that OK for you? |
Yes, your summary is correct. (And I agree with @fantasai 100% here.) |
I agree it's desirable, but I was left under the impression that this made some of the steps too big for blink and webkit's tastes, and that you intentionally shipped things that were only implemented for grid because updating flexbox increased the size of the task by too much. I'd be happy if this was a misunderstanding though. @mrego @javifernandez, any thoughts? |
Added to FTF agenda |
The CSS Working Group just discussed partial implementations of space-evenly in grid but not flexbox. The full IRC log of that discussion
|
I started to work on a fix for Blink/Chrome in the bug https://crbug.com/170445, reported by @frivoal. BTW, shouldn't the Flexbox spec be updated accordingly ? It still refers to the old values: https://drafts.csswg.org/css-flexbox/#justify-content-property
|
It seems that a bit similar problem is there in Safari with |
Re: the original issue, WebKit fixed its support of Re: |
@hober I added a comment to the bug already filed by you: https://bugs.webkit.org/show_bug.cgi?id=157477#c2 |
See this twitter conversation: https://twitter.com/lajava77/status/849182533791227904
TL;DR: Safari and Chrome ship
justify-content: space-evenly
, but it only works in grid, not in flexbox.In their implementations, in flexbox, it falls back to the same behavior as
flex-start
. But since it parses fine, you cannot use the cascade or@support
to provide a different fallback.The real solution is for both browsers to fix this by completing their implementation, but my question is:
justify-content: space-evenly
until then (even though it works fine in grid)?justify-content: space-around
(most similar) orjustify-content: center
(specified as the fallback alignment, for different situations)?Should the spec say something about this particular kind of partial implementations, besides what's already in https://drafts.csswg.org/css-align/#conform-partial
@mrego @javifernandez @tabatkins @fantasai
The text was updated successfully, but these errors were encountered: