Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent -> Thorough #151

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Consistent -> Thorough #151

merged 2 commits into from
Jan 29, 2024

Conversation

cwilso
Copy link
Collaborator
@cwilso cwilso commented Jan 27, 2024 •
edited by pr-preview bot
Loading

Fixes #117

Preview | Diff

@cwilso cwilso requested a review from frivoal January 27, 2024 01:39
tantek
tantek approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member
@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except I suggest also a minor grammar fix, "consistent horizontal reviews" (plural) since it's followed by a list, and in practice they are multiple horizontal reviews.

@cwilso
Copy link
Collaborator Author
cwilso commented Jan 27, 2024

It was actually intentional to denote thorough review as a singular category, rather than plural to denote each current horizontal review. Although it's followed by an illustrative list, it wasn't intended to be a closed-ended list (for example, the W3C Community might consider adding new aspects to that list (like we just added sustainability, despite not yet having an in-place horizontal review process for it).

Noting that, I changed the text, ptal.

tantek
tantek approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member
@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and this is a good clarifying edit. LGTM.

@cwilso cwilso merged commit 5fe0bad into main Jan 29, 2024
4 checks passed
@cwilso cwilso deleted the thorough-review branch January 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horizontal review
2 participants
@cwilso @tantek