You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I first started developing bioslam, gtsam only had a magnetometer factor which hooked into a Rot3 object, not a Pose3 object (which are the objects we use to store the pose of IMUs in bioslam). So I developed a custom factor (MagPose3Factor) to add a magnetometer factor to a Pose3 object. Recently, a pull request was merged on gtsam that added a factor which does exactly what I wanted in the first place. It adds the factor MagPoseFactor which is probably way more robust and better-tested than the one I had made. We should switch bioslam to use this.
What to do:
Swap out bioslam's custom MagPose3Factor with the new gtsam built-in MagPoseFactor.
Caveats:
This new GTSAM factor just got merged and won't be available in an official GTSAM release til GTSAM 4.1. So don't do this switch until GTSAM 4.1 is out and we force bioslam to require GTSAM >= 4.1.
Right now it's in gtsam_unstable, and I'm not sure why. Consider if we want bioslam to depend on gtsam_unstable components.
Background:
When I first started developing bioslam, gtsam only had a magnetometer factor which hooked into a
Rot3
object, not aPose3
object (which are the objects we use to store the pose of IMUs in bioslam). So I developed a custom factor (MagPose3Factor
) to add a magnetometer factor to aPose3
object. Recently, a pull request was merged on gtsam that added a factor which does exactly what I wanted in the first place. It adds the factorMagPoseFactor
which is probably way more robust and better-tested than the one I had made. We should switch bioslam to use this.What to do:
Swap out bioslam's custom
MagPose3Factor
with the new gtsam built-inMagPoseFactor
.Caveats:
Right now it's in gtsam_unstable, and I'm not sure why. Consider if we want bioslam to depend ongtsam_unstable
components.The text was updated successfully, but these errors were encountered: