Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling docs #1040

Open
hadley opened this issue Jan 4, 2023 · 5 comments
Open

Update error handling docs #1040

hadley opened this issue Jan 4, 2023 · 5 comments

Comments

@hadley
Copy link
Member
hadley commented Jan 4, 2023

Once r-lib/rlang#1533 and r-lib/rlang#1534 are in a released version of rlang.

@lbui30
Copy link
lbui30 commented Feb 6, 2023

No sure where this would go in your task schedule, but this broke in tidymodels.
tidymodels/recipes#1081

P.S. I am going to go back to having to a roll back of every package in tidyverse due to this bugs similar to this one.

@hadley
Copy link
Member Author
hadley commented Feb 6, 2023

@lbui30 as requested in that issue, I think you need to start by providing a reprex.

@EmilHvitfeldt
Copy link

With the help of @lbui30, we were able to locate the problem which happened with a modification of an example we had on tidymodels.org. Thus purrr wasn't at fault.

@lbui30
Copy link
lbui30 commented Feb 19, 2023

Thanks @EmilHvitfeldt is correct. However, something about purr or the tidyverse does make the output of errors still bit confusing to figure out. So, I was recommended by a co-worker to bring this up here as a motivating example of the need to have clearer error handling messages.

Errors were so much easier when they referenced code line numbers and had a common sense order in them. If there is anyway to help the reader identify the lines of code better in the new error handling docs, then I think that would be a great contribution.

@hadley
Copy link
Member Author
hadley commented Feb 19, 2023

@lbui30 we have done our best to make the errors informative and actionable, so if you have a counter example, we'd really appreciate seeing a reprex that illustrates it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants