Fixes #38044 - Don't accept negative values for OS major version #10388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lennonka
reviewed
Nov 26, 2024
app/models/operatingsystem.rb
Outdated
| @@ -22,7 +22,7 @@ class Operatingsystem < ApplicationRecord | |||
| accepts_nested_attributes_for :os_default_templates, :allow_destroy => true, | |||
| :reject_if => :reject_empty_provisioning_template | |||
|
|
|||
| validates :major, numericality: true, presence: { message: N_("Operating System version is required") } | |||
| validates :major, numericality: {:greater_than_or_equal_to => 0, :message => N_("Major version should be greater than or equal to 0") }, presence: { message: N_("Operating System version is required") } | |||
There was a problem hiding this comment.
Suggested change
| validates :major, numericality: {:greater_than_or_equal_to => 0, :message => N_("Major version should be greater than or equal to 0") }, presence: { message: N_("Operating System version is required") } | |
| validates :major, numericality: {:greater_than_or_equal_to => 0, :message => N_("Major version of the operating system must be greater than or equal to 0") }, presence: { message: N_("Operating System version is required") } |
I'm not sure what the context for this text is, but I'd include the words "operating system". Also, it's a hard requirement, so "must".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.