Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make renderDate private? #82

Open
Ryuno-Ki opened this issue Mar 1, 2023 · 0 comments
Open

Make renderDate private? #82

Ryuno-Ki opened this issue Mar 1, 2023 · 0 comments

Comments

@Ryuno-Ki
Copy link
Ryuno-Ki commented Mar 1, 2023

Looking at

tweetback/src/twitter.js

Lines 286 to 289 in d03e289

renderDate(d) {
let months = ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"];
return `${d.getFullYear()} ${months[d.getMonth()]} ${d.getDate()}`;
}

it appears to be used only within this class. Therefore I suggest to declare it as a private method (by prefixing it with an underscore or using private class feature).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ryuno-Ki