feat: show sources on alternate display #520
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid be
30CC
cause no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a fix to #390:
When printing an error that has the
Snafu
derive with the alternate display formatter ({err:#}
), the list of sources is attached, similar to how anyhow does it.This is similar to the
Report
, but without needing to take ownership of the error (whichReport
requireds) and without spreading the display over multiple lines.It is especially useful when logging errors while also bubbling them up. We frequently want to log errors, and currently this will not print the source chain, rendering the log mostly irrelevant. With this change, you can do
And get a log like
(from the
simple
example - which I can remove of course if this PR is being considered for merging).