Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum validators CL and EL events should respect the ownership percentage #8438

Open
LefterisJP opened this issue Aug 22, 2024 · 4 comments

Comments

@LefterisJP
Copy link
Member

Abstract

A user (@gnidan) requested this. At the moment rotki does not respect validator percentage when creating withdrawal events (CL rewards) or block/mev events (EL rewards).

Ideally rotki should check the validator ownership percentage and for each of those make sure that events count the reward with the given percentage.

What's more if the user edits the validator percentage all events should be recalculated.

Task

  • See how hard it would be to do
  • Spec it out
  • Maybe do it (update this section then)
@gnidan
Copy link
Contributor
gnidan commented Aug 22, 2024

Possible bug that's related to this thematically: APR values are incorrect by a factor of ownership percentage.

I jointly own a validator (50%/50%), and I operate this validator through an account owned entirely by me. To address the accounting discrepancy, I have customized the events for the validator deposit and all block rewards+withdrawals to use 50% amounts (since I only paid half the deposit, and I only earn half of the rewards). Problem is, when I look at the APR on the staking dashboard, it appears to be computing the percentage based on my share of the earnings (this is correct), but based on the full joint investment of 32 ETH (this is not correct), so as a result, the APR is half of what it should be. This then lowers my average APR for all my validators, making it harder to get a proper sense for financial performance.

@LefterisJP
Copy link
Member Author

Possible bug that's related to this thematically: APR values are incorrect by a factor of ownership percentage.

I jointly own a validator (50%/50%), and I operate this validator through an account owned entirely by me. To address the accounting discrepancy, I have customized the events for the validator deposit and all block rewards+withdrawals to use 50% amounts (since I only paid half the deposit, and I only earn half of the rewards). Problem is, when I look at the APR on the staking dashboard, it appears to be computing the percentage based on my share of the earnings (this is correct), but based on the full joint investment of 32 ETH (this is not correct), so as a result, the APR is half of what it should be. This then lowers my average APR for all my validators, making it harder to get a proper sense for financial performance.

this is for the performance in the eth staking view right? And yes there it's not take into account either and could also be done.

@gnidan
Copy link
Contributor
gnidan commented Aug 22, 2024

this is for the performance in the eth staking view right?

That's right - the "Staking per Validator" table has the wrong APR for the shared validator, and the "Staking / ETH" Overview panel also uses the incorrect APR value.

@gnidan
Copy link
Contributor
gnidan commented Sep 13, 2024

Another thought of how to do this accounting is to make the events have a debt component and an earning component... so when I get a block reward, my account gets all the funds, but it's also marked with a "Generate Debt" event... then when I disburse the funds that don't belong to me, I can just mark it as "Repay Debt"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants