Fix #150: Allow bag_to_pcd to properly respond to topic argument #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously providing a topic name in argv[2], as indicated in the usage string, modified the printouts indicating to the user that they were going to be exporting the correct topic, but the rosbag::View::Query used still grabbed the first sensor_msgs/PointCloud2 topic which was not necessarily what they had specified.
|
LGTM, thanks! CI failures due to unsupported platforms that have been removed on master. |
paulbovbel
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument was ignored before, as reported in #150
Also added some more helpful printout information in case user provides wrong topic name or type.