-
-
Notifications
You must be signed in to change notification settings - Fork 924
[POC] Debugger #9373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CUB3D
wants to merge
19
commits into
ruffle-rs:master
Choose a base branch
from
CUB3D:ruffle-debugger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[POC] Debugger #9373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ren and generic do-defined info
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word "debug" no longer bears any meaning for me.
This is extremely POC and not ready for any serious review as of yet, but I'm making this pr to get some feedback on what I have so far.
This adds the capability to interactively debug SWFs running under Ruffle, the current protocol is not compatible with
FDB
orJPEXS
as of yet (see below) however does have a couple of advantages:web
andextension
platforms, (FDB
uses raw TCP so this won't be possible)Additionally, while
JPEXS
devs have done some reverse-engineering of theFDB
protocol, this is mainly from the debugger side, so figuring out the debugee side will require some additional work.Currently this implementation provides:
desktop
only, usingtungstenite
for websockets, as web will require the use of a different librarydebugger/src/command_parser.rs
Currently all changes to both
desktop
andcore
are blocked behind thedebugger
feature, it's intended that these changes should have no effect when that feature is not enabled.Note that versions of Flash Player intended for debugging restrict the ability to debug "production" SWF files that do not contain
EnableDebugger2
tags and the like, it is intentional that this debugging feature does not enforce this, nor should it depend on any of the debugging specific information that can be embedded in SWFs using AVM2 where feasible. Any site that would like to prevent debugging should simply not enable thedebugging
feature (which will be disabled by default). This tooling is intended for use by Ruffle contributors for understanding and resolving issues first and foremost, and hence needs to be "useful" in as many scenarios as possible.Current Features
Player Commands:
Display Object commands:
AVM1 Commands:
Things to be figured out:
FDB
via a separate backend or by using some kind of proxy, the later would allow us to use JPEXS debugger on web at the cost of needing to run some kind of bridge