Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results are not saved with Size and Name search "Failed to save results to file key must be a string" #1137

Closed
richrboo opened this issue Nov 18, 2023 · 1 comment · Fixed by #1102
Closed

Results are not saved with Size and Name search "Failed to save results to file key must be a string" #1137

richrboo opened this issue Nov 18, 2023 · 1 comment · Fixed by #1102
Labels
bug Something isn't working

Comments

@richrboo
Copy link

Desktop (please complete the following information):

  • Czkawka version 6.1.0 gui flatpak
  • OS version Fedora 38
  • Terminal output[optional]:

Bug Description
Performing a search on Size and Name, then pressing the save button in the gui to save the results, gives an error "Failed to save results to file key must be a string" and the results are not saved, other than a broken/ empty pretty json file.

The save does work as expected with the Hash check method and the Name only method.
@richrboo richrboo added the bug Something isn't working label Nov 18, 2023
@qarmin
Copy link
Owner
qarmin commented Nov 18, 2023

Problem happens because it try to save results with type BTreeMap<(u64, String), Vec<FileEntry>>, but serde throws error key must be a string.

This is not supported by serde - serde-rs/json#887 and the simplest solution is to convert BTreeMap into Vec<> which I already done in #1102

@qarmin qarmin mentioned this issue Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alternative frontend with Slint qarmin/czkawka
2 participants
@richrboo @qarmin