Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to long #96

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Add timestamp to long #96

merged 2 commits into from
Dec 2, 2019

Conversation

clickingbuttons
Copy link
Contributor

Add web console to_long function. Tested with select to_long(to_timestamp(1262596503400000L)) from long_sequence(1)

@claassistantio
Copy link
claassistantio commented Nov 30, 2019

CLA assistant check
All committers have signed the CLA.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bluestreak01 bluestreak01 self-requested a review November 30, 2019 22:58
@bluestreak01
Copy link
Member

Thank you very much for the contribution!

To maintain overall code quality we also require a test for this function. There is plenty of test infrastructure around and writing one should be quite easy. Please have a look at this test for an inspiration:

https://github.com/questdb/questdb/blob/master/core/src/test/java/io/questdb/griffin/engine/functions/regex/NotMatchStrFunctionFactoryTest.java

Copy link
Member
@bluestreak01 bluestreak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks great, thanks! We just need a test and we good to go!

@bluestreak01 bluestreak01 merged commit 5190a54 into questdb:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants