Add remote-write to Prombench #787
Conversation
3cd3530
to
e199dc3
Compare
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
e199dc3
to
1eab9a1
Compare
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: prometheus-remote-write |
There was a problem hiding this comment.
I think it might be easier if this were named the same as the Deployment.
That's the pattern used for fake-webserver, prometheus-loadgen-querier.
| name: prometheus-remote-write | ||
| namespace: prombench-{{ .PR_NUMBER }} | ||
| labels: | ||
| app: remote-write |
There was a problem hiding this comment.
This should be consistent with other app labels in this file.
That's the point, to group them all together.
There was a problem hiding this comment.
i did not knew that.
| spec: | ||
| ports: | ||
| - name: prometheus | ||
| port: 80 |
There was a problem hiding this comment.
Why? (It doesn't really matter, but I would have stuck with 9011)
| app: remote-write | ||
| spec: | ||
| ports: | ||
| - name: prometheus |
There was a problem hiding this comment.
This seems potentially confusing; it's not a Prometheus.
| @@ -718,3 +718,5 @@ data: | |||
| - action: replace | |||
| source_labels: [__meta_kubernetes_pod_node_name] | |||
| target_label: nodeName | |||
| remote_write: | |||
| - url: "http://prometheus-remote-write:80/sink/prw" | |||
Services are either headless or ClusterIP, not both. See https://kubernetes.io/docs/concepts/services-networking/service/#type-clusterip |
279f28f
to
187ee64
Compare
2. make clusterIp headless. Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
187ee64
to
5d1d7c1
Compare
| limits: | ||
| cpu: "1" | ||
| memory: "350Mi" |
There was a problem hiding this comment.
Leave off limits until we know more about what it needs.
If it hits the memory limit it will crash, which will be annoying.
Signed-off-by: Kushal Shukla <kushalshukla110@gmail.com>
| app: sink | ||
| template: | ||
| metadata: | ||
| namespace: prombench-{{ .PR_NUMBER }} |
There was a problem hiding this comment.
Normally containers inherit the namespace from the Deployment.
Maybe it will work.
This PR introduces a Deployment and a Service to test the Prometheus Remote Write functionality.
Currently, the image for the Prometheus sink is not applied in the YAML file. To address this, I have created a basic YAML configuration that sets up the necessary Deployment and Service to test the Prometheus Remote Write functionality.
(quay.io/bwplotka/sink:latest).The container exposes port 9011 as sink-port.port 80and forward traffic to thesink-porton the pods.