fix: improve column type info #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b90f9d
to
2760050
Compare
Weakky
commented
Jul 17, 2024
| @@ -7,11 +7,13 @@ pub struct TokenFeatureExtAck { | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
All of these are clippy fixes coming from Rust 1.79.0. I don't want to remove all of this code until we give tiberius proper attention again.
There was a problem hiding this comment.
Hm, github's mentioning a bunch of clippy warnings in files that weren't in this PR, I guess those are also to be left until this happens
Druue
approved these changes
Jul 18, 2024
apolanc
approved these changes
Jul 19, 2024
Weakky
added a commit
that referenced
this pull request
Jul 19, 2024
Weakky
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to https://github.com/prisma/team-orm/issues/1222.
Improve column type information so that Quaint can better infer its own
ColumnTypefor the TypedSQL initiative.