Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LogoutButton #2894

Open
AnnMarieW opened this issue Jun 18, 2024 · 8 comments · Fixed by #2899
Open

Remove LogoutButton #2894

AnnMarieW opened this issue Jun 18, 2024 · 8 comments · Fixed by #2899
Labels
dash-3.0 Going in dash-3.0 release. feature something new good first issue suitable for newcomers P3 backlog

Comments

@AnnMarieW
Copy link
Collaborator
AnnMarieW commented Jun 18, 2024 •
edited
Loading

Since dcc.LogoutButton is no longer recommended, it should be removed.

The docs page will be redirected to html.Button.
https://github.com/plotly/ddk-dash-docs/issues/2603

This is a great "first issue" for anyone looking to contribute, and I'm happy to help you get started! If no one takes it on within about a week, I'll handle it as part of the docs PR I'm working on,
@AnnMarieW AnnMarieW added the good first issue suitable for newcomers label Jun 18, 2024
@shawon-majid
Copy link

Hi, I'm new open source, sorry if this is silly question, But the given link is not working.

@AnnMarieW
Copy link
Collaborator Author

Hi @shawon-majid and welcome!
That link is to the dash docs library, which is private. The relevant content is only about how the LogoutButton should be removed, which lead to opening this issue.

Is this something you are interested in working on?

@AnnMarieW
Copy link
Collaborator Author

Note - This might be considered a breaking change - may need to deprecate this component, then remove it in dash 3.0

@T4rk1n
Copy link
Contributor
T4rk1n commented Jun 18, 2024

Note - This might be considered a breaking change - may need to deprecate this component, then remove it in dash 3.0

Not sure we have an easy way of deprecating components, maybe we can check the class attribute (_namespace, _type) is not in a list and emit a deprecation warning in here:

dash/dash/_validate.py

Line 412 in 685dcbc

def validate_layout(layout, layout_value):

@leeagustin leeagustin mentioned this issue Jun 22, 2024
Merged
9 tasks
@shreya1728
Copy link
shreya1728 commented Jun 25, 2024 •
edited
Loading

Hi, I've worked on a dash app on a project so I'm quite familiar with it. I'm new to open-source and would love to contribute to this issue. Could you please assign it to me?

@T4rk1n
Copy link
Contributor
T4rk1n commented Jun 25, 2024

Hi @shreya1728 there is already a PR for this issue, #2899

@AnnMarieW
Copy link
Collaborator Author

@shreya1728 Thanks for your offer to contribute!
Let us know if you are interested in helping with any other issues 🙂

@gvwilson gvwilson assigned gvwilson and unassigned gvwilson Jul 26, 2024
@gvwilson gvwilson added the P3 backlog label Aug 13, 2024
@gvwilson gvwilson added the feature something new label Aug 13, 2024
@T4rk1n T4rk1n added the dash-3.0 Going in dash-3.0 release. label Sep 4, 2024
@Gannu456
Copy link
Gannu456 commented Nov 21, 2024 •
edited
Loading

@AnnMarieW I ran into this issue very late as somebody already submitted the pr for this.
I would love to contribute to other issues....could you please give me a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dash-3.0 Going in dash-3.0 release. feature something new good first issue suitable for newcomers P3 backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate LogoutButton leeagustin/dash
7 participants
@gvwilson @marthacryan @T4rk1n @shawon-majid @AnnMarieW @shreya1728 @Gannu456