Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable color output for diff #179

Open
yaroslavyaroslav opened this issue Aug 2, 2024 · 2 comments
Open

Option to disable color output for diff #179

yaroslavyaroslav opened this issue Aug 2, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@yaroslavyaroslav
Copy link
yaroslavyaroslav commented Aug 2, 2024

The issue is that I wish to forward plandex diff to my tool of choice to review diffs. And I succeeded with that by ksdiff <(plandex diff), but it looks like this there:

�[1mindex 660fa03..d43bc40 100644�[m
�[1m--- a/.github/workflows/doc2dash.yml�[m
�[1m+++ b/.github/workflows/doc2dash.yml�[m

UPD: It'd be a way better to add a general colorless toggle for the whole plandex tool rather than to diff only command.

@danenania
Copy link
Contributor

Thanks @yaroslavyaroslav, agreed! We have a --plain/-p flag for both convo and summary commands, so we should add one for diff as well. A top-level setting is also a good idea, perhaps through an env var.

@danenania danenania added the good first issue Good for newcomers label Aug 3, 2024
@ryanwith
Copy link
Contributor

Created a PR that addresses this: #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants