Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH2: Reorganize get_binary_packet to fetch entire packet before processing #2006

Merged
merged 3 commits into from
May 29, 2024

Conversation

rposky
Copy link
Contributor
@rposky rposky commented May 28, 2024

See original PR #1999, rebased onto 3.0 branch here.

…rocessing, buffering for graceful handling across timeouts.

Remove skip filter parameter from method signatures, now technically defunct as all requests through get_binary_packet incorporate the same timeout during blocking IO calls.
Introduce InvalidPacketLength exception and employ to detect OpenSSL 0.9.8e flaw at higher logical level than binary packet processing.
Removing case logic in binary packet filtering for channel message types, made extraneous by use of get_channel_packet, and possibly leading to discarded data packets.
Reset connection properties during disconnect. Rework callers of reset_connection to use disconnect_helper.
Bugfix for no encyrption algorithms negotiated with server.
@terrafrost terrafrost merged commit 38de2d9 into phpseclib:3.0 May 29, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants