Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing warning when blocking entity loading via libxml_set_external_entity_loader #11952

Closed
nielsdos opened this issue Aug 12, 2023 · 0 comments
Closed

Confusing warning when blocking entity loading via libxml_set_external_entity_loader #11952

nielsdos opened this issue Aug 12, 2023 · 0 comments
Labels
Bug Extension: libxml Status: Verified

Comments

@nielsdos
Copy link
Member

Description

The following code:

<?php

libxml_set_external_entity_loader(function ($public_id, $system_id, $context) {
    return null;
});

$doc = new DOMDocument;
$doc->loadHTMLFile("foobar");

Resulted in this output:

Warning: DOMDocument::loadHTMLFile(): Failed to load external entity "NULL" in %s on line %d

But I expected something less confusing. Now it sounds like it tries to load a file named "NULL" but that is not the case. It just complains in a weird way.
Low priority issue though.

PHP Version

8.1+

Operating System

No response
nielsdos added a commit to nielsdos/php-src that referenced this issue Aug 22, 2023
@nielsdos
Improve warning when returning null from the resolver set by libxml_s…
d19eba1 
…et_external_entity_loader

Fixes phpGH-11952.
@nielsdos nielsdos mentioned this issue Aug 22, 2023
Closed
jorgsowa pushed a commit to jorgsowa/php-src that referenced this issue Aug 24, 2023
@nielsdos @jorgsowa
Improve warning when returning null from the resolver set by libxml_s…
bf1adb1 
…et_external_entity_loader

Fixes phpGH-11952.
Closes phpGH-12022.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Extension: libxml Status: Verified
Projects
None yet
Milestone
No milestone
1 participant
@nielsdos