Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking for php... php #11522

Closed
SVGAnimate opened this issue Jun 24, 2023 · 2 comments
Closed

checking for php... php #11522

SVGAnimate opened this issue Jun 24, 2023 · 2 comments
Labels
Bug Category: Build System Status: Verified

Comments

@SVGAnimate
Copy link
Contributor

Description

Build complete. But :

The following code:

user@host:/path/php-src/$ ./configure

Resulted in this output:

...
expr: non-integer argument
checking for php version... 7.2.24-0ubuntu0.16.04.16 (ok)
checking whether to enable computed goto gcc extension with re2c... no
/path/php-src/configure: line 5862: test: : integer expression expected
...
Thank you for using PHP.

But I expected this output instead:

checking for php version... 7.2.24 (too old)

PHP Version

PHP 8.2.8

Operating System

Ubuntu 16
@SVGAnimate
Copy link
Contributor Author
SVGAnimate commented Jun 24, 2023 •
edited
Loading

To fix the "too old" error, I can run the configuration again with a specific version (the newly compiled php version) as well

user@host:/path/php-src/$ export PHP=/path/php-src/sapi/cli/php && ./configure

Resulted in this output:

expr: non-integer argument
/path/php-src/configure: line 5862: test: : integer expression expected
checking for php version... 8.2.8-dev (ok)

But I expected this output instead:

checking for php version... 8.2.8 (ok)

Can we fix this bug like this ? https://github.com/SVGAnimate/php-src/blob/m4_php_version_cut_suffix/build/php.m4#L1895

@nielsdos
Copy link
Member

@SVGAnimate
I can reproduce this with 8.3-dev. And your fix looks okay I think.

@nielsdos nielsdos linked a pull request Jun 27, 2023 that will close this issue
fix #11522 #11524
Closed
nielsdos added a commit that referenced this issue Jun 27, 2023
@nielsdos
Merge branch 'PHP-8.1' into PHP-8.2
ac60c5c 
* PHP-8.1:
  Fix GH-11522: PHP version check fails with '-' separator
nielsdos added a commit that referenced this issue Jun 27, 2023
@nielsdos
Merge branch 'PHP-8.2'
864c307 
* PHP-8.2:
  Fix GH-11522: PHP version check fails with '-' separator
@timnolte timnolte mentioned this issue Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Category: Build System Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #11522 SVGAnimate/php-src
3 participants
@nielsdos @Girgias @SVGAnimate