-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Labels
Milestone
Description
Describe the bug
GitHub Actions cannot run for the operational test, due to poor memory management.
To Reproduce
Steps to reproduce the behavior:
- Go to
pysat/pysat/tests/classes/cls_instrument_library.py
- Change the
pytest.skip
conditions to allow Python 3.6 to run for thetest_load_w_pad
test. - Perform the full unit test suite.
- See error
Expected behavior
These tests will pass without the full suite locally and the behaviour is correct in iPython. The full test suite should run.
Desktop (please complete the following information):
- OS: GitHub Actions Ubuntu
- Version: Python 3.6
- Other details about your setup that could be relevant
Additional context
The error we are getting is that too much memory is being used. I was able to significantly reduce memory usage in Instrument.load
by making changes to __getitem__
. It is likely that the use of __slots__
(which requires removing weakref usage), and improving other algorithmic redundancies can solve this problem.