Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unvendor pyodide-build #4882

Merged
merged 33 commits into from
Jul 26, 2024
Merged

Unvendor pyodide-build #4882

merged 33 commits into from
Jul 26, 2024

Conversation

ryanking13
Copy link
Member
@ryanking13 ryanking13 commented Jun 23, 2024 •
edited
Loading

Description

pyodide-build now lives in pyodide/pyodide-build.

After this change,

  1. pyodide-build will have separate version numbers from Pyodide runtime. Actually, I just released pyodide-build 0.27, so it is already separated
  2. If some change needs to be applied both in pyodide runtime and pyodide-build, it will be a little more uncomfortable. One should bump up pyodide-build first, and then update pyodide runtime. I've worked to loosen the connection between the two as much as possible to prevent this from happening, but as always, it can happen.

This was referenced Jun 29, 2024
Closed
Merged
@ryanking13 ryanking13 mentioned this pull request Jul 6, 2024
Open
@ryanking13
Copy link
Member Author

This is ready to be reviewed now.

hoodmane
hoodmane reviewed Jul 17, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
hoodmane
hoodmane reviewed Jul 17, 2024
View reviewed changes
Makefile.envs Outdated
@@ -2,6 +2,7 @@ export PYVERSION ?= 3.12.1
export PYODIDE_EMSCRIPTEN_VERSION ?= 3.1.58
export PYODIDE_VERSION ?= 0.27.0.dev0
export PYODIDE_ABI_VERSION ?= 2024_0
export PYODIDE_BUILD_VERSION ?= 0.27.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add optional PYODIDE_BUILD_REPO and PYODIDE_BUILD_COMMIT -- if these are defined, we can check in the pyodide_build rule that direct_url.json exists and has appropriate contents. Then perhaps we should install pyodide_build everywhere with make pyodide_build...?

Copy link
Member Author
@ryanking13 ryanking13 Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me. Let me see if I can make it work.

@ryanking13 ryanking13 mentioned this pull request Jul 19, 2024
Closed
1 task
hoodmane
hoodmane reviewed Jul 23, 2024
View reviewed changes
.github/workflows/main.yml
@@ -43,7 +41,7 @@ jobs:
--verbose \
--runtime=host \
--cov=pyodide_build --cov=pyodide \
src pyodide-build packages/micropip/ packages/_tests tools/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you deleted packages/micropip and packages/_tests here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put back packages/_tests. packages/micropip is not needed as there is no host test in micropip anyway.

hoodmane
hoodmane approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member
@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryanking13 ryanking13 merged commit 8fbf592 into pyodide:main Jul 26, 2024
40 of 41 checks passed
@ryanking13 ryanking13 deleted the unvendor-build branch July 26, 2024 14:52
@agriyakhetarpal agriyakhetarpal mentioned this pull request Sep 11, 2024
Draft
@agriyakhetarpal agriyakhetarpal mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanking13 @hoodmane