Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendToDesktop keeps focus with follow="no" #1800

Closed
Vladimir-csp opened this issue May 12, 2024 · 8 comments
Closed

SendToDesktop keeps focus with follow="no" #1800

Vladimir-csp opened this issue May 12, 2024 · 8 comments
Labels
bug Something isn't working PR pending PR to fix the issue is already pending UX User Experience issues
Milestone

Comments

@Vladimir-csp
Copy link

Window is somewhere else, but still receives input.

@Vladimir-csp
Copy link
Author

Strangely, could not work around it by adding a second action Unfocus

    <keybind key="C-W-1">
      <action name="SendToDesktop" to="1" follow="no" />
      <action name="Unfocus" />
    </keybind>
    <keybind key="C-W-2">
    ...

@Vladimir-csp
Copy link
Author

...and putting Unfocus first makes it the only action applied to the window. So each action in the keybind checks for a focused window, not a single check per keybind?

@droc12345
Copy link
Contributor

If you unfocus first how does it know which window to send?

And yes, each action checks things for itself, the actions are not chained, just executed one after another.

@Consolatis Consolatis added bug Something isn't working UX User Experience issues labels May 12, 2024
@Consolatis Consolatis added this to the 0.7.3 milestone May 12, 2024
@Consolatis
Copy link
Member

Window is somewhere else, but still receives input.

Thanks for the report. We should indeed focus the then topmost window on the current workspace.

@Vladimir-csp
Copy link
Author

Why does sending+unfocusing workaround not work? Window is still focused, so Unfocus action should apply, but it does not. Could be an indication of a hidden bug.

@Consolatis
Copy link
Member

From a quick look in the code, Unfocus only resets the keyboard focus, it will not focus the topmost surface. So further input should then not be relayed to the now hidden window. Is that actually the case?

@Vladimir-csp
Copy link
Author

Yes, input stops, and no other window is focused.

@Vladimir-csp
Copy link
Author

Usable workaround: add NextWindow action.

Consolatis added a commit to Consolatis/labwc that referenced this issue May 18, 2024
@Consolatis Consolatis added the PR pending PR to fix the issue is already pending label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR pending PR to fix the issue is already pending UX User Experience issues
Projects
None yet
Development

No branches or pull requests

3 participants