Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SOLD2Net to Support Dataclasses for Configuration #2908

Open
Tracked by #2093
lappemic opened this issue May 16, 2024 · 1 comment
Open
Tracked by #2093

Refactor SOLD2Net to Support Dataclasses for Configuration #2908

lappemic opened this issue May 16, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@lappemic
Copy link
Contributor

In the process of updating dictionary configurations to dataclasses (see #2093), I noticed that kornia.feature.sold2.backbones.SOLD2Net currently also only supports dictionaries. This restriction was addressed by using the dataclass_to_dicts function a previous commit (see details). To maintain consistency with the ongoing dataclasses for config refactoring effort, should SOLD2Net be updated to accept dataclasses directly?
@lappemic lappemic added the help wanted Extra attention is needed label May 16, 2024
@johnnv1
Copy link
Member
johnnv1 commented May 16, 2024

Yes, although it doesn't matter as much because it's more for “internal” use, I think it's great to keep it consistent -- and I think it's more legible

@johnnv1 johnnv1 mentioned this issue May 16, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnnv1 @lappemic