This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Use --network-namespace-path= instead of relying on ns.Set() #348

Open

arianvp opened this issue Sep 28, 2019 · 1 comment

arianvp commented

I was wondering why we don't set --network-namespace-path=<path-to-ns>

In cnispawn, Would be something like:

path := ns.Path()

nspawnOpts := append(nspawnOpts, fmt.Printf("--network-namespace-path=%s", path))

Instead, we seem to be calling ns.Set(). Which can be a bit unsafe in presence of goroutines (https://github.com/containernetworking/plugins/blob/master/pkg/ns/README.md)

The text was updated successfully, but these errors were encountered:

Author

arianvp commented

This is more of a question out of interest then a request or a bug report. Feel free to close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.