Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DistributedBucketSampler : create bucket sampler issue. #194

Open
YoungJae98 opened this issue Nov 11, 2023 · 1 comment
Open

DistributedBucketSampler : create bucket sampler issue. #194

YoungJae98 opened this issue Nov 11, 2023 · 1 comment

Comments

@YoungJae98
Copy link

In DistributedBucketSampler's create_bucket function, there is a loop that detects and pops empty bucket.

The range is set from len(bucket)-1 to 0. In this range, first index is not referenced. Then error can occur if the first part is empty.

I wonder if I got it wrong, if not with any other intentions.
@YoungJae98
Copy link
Author
YoungJae98 commented Nov 11, 2023 •
edited
Loading

영어로 적다보니 의도가 다르게 전달됐을까 하여 한글로도 남깁니다..! distributed bucket sampler에서 bucket pop하는 부분에 현재처럼 0까지만 돌게되면 index 1까지만 순회하게 되는데, 그렇게되면 index 0일 경우에 비어있다면 비우지 못해서 다음 구간에서 오류가 발생할 수 있는것이 아닌가 하는 생각이 들어서 혹시 다른 의도가 있으셨던건지, 아니라면 제가 잘못 이해한건지 여쭤보고싶어 이슈로 남겼습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YoungJae98