Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the functionality to open Google Images tab and other tabs in the Google Images page, adapting to recent changes in Google's URL structure and page layout.
Related Issues
Changes
Reason for Changes
Google Images Tab
Google recently changed the URL structure for Google Images, removing the
tbm=isch
parameter that was previously used to identify image search results. This change broke our existing functionality for opening the Google Images tab.Technical Details
'a[href*="&tbm=isch"]'
to identify the Google Images tab.tbm
parameter is no longer present in the URL.udm=2
in the URL for image search results.udm=2
instead oftbm=isch
.Other Tabs in Google Images Page
In addition to the URL structure change, Google also modified the selectors for other tabs in the Google Images page. This necessitated further updates to our codebase.
Technical Details
Implementation
udm=2
parameter to identify and interact with Google Images tabs.References