Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h-card validator should prefer representative h-card #109

Closed
snarfed opened this issue Nov 13, 2022 · 3 comments
Closed

h-card validator should prefer representative h-card #109

snarfed opened this issue Nov 13, 2022 · 3 comments

Comments

@snarfed
Copy link
Member
snarfed commented Nov 13, 2022

It looks like the h-card validator currently uses the first h-card it finds on the page. I suspect we instead want it to use the representative h-card algorithm, or if that's too much, at least the top-level h-card. The current result for eg https://indiewebify.me/validate-h-card/?url=https%3A%2F%2Fwebrocker.de shows an h-card with a u-photo from an h-entry, which is misleading, since the representative h-card doesn't have a u-photo.

cc @barnabywalters @gRegorLove
@gRegorLove
Copy link
Member

Hmm, I thought it should be using representative h-card already. I'll check, thanks!

@gRegorLove
Copy link
Member

I think something might not have gone right with the deploy after #101 merged -- maybe the dependencies didn't update? I'm not really familiar with how the deploy process works.

On my test version with #101, it's finding the rep h-card correctly: https://iwm.gregoreatworld.com/validate-h-card/?url=https%3A%2F%2Fwebrocker.de

@gRegorLove
Copy link
Member

This should be fixed now with #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snarfed @gRegorLove