Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Check your homepage h-card" doesn't pick up u-photo unless it's nested directly under the h-card tag #90

Open
MaybeThisIsRu opened this issue Sep 4, 2020 · 1 comment
Open

"Check your homepage h-card" doesn't pick up u-photo unless it's nested directly under the h-card tag #90

MaybeThisIsRu opened this issue Sep 4, 2020 · 1 comment

Comments

@MaybeThisIsRu
Copy link
MaybeThisIsRu commented Sep 4, 2020 •
edited
Loading

IndieWeb IRC chat for reference.

I have my u-photo nested two or three divs under the h-card div. This causes IndieWebify.me to not pick up my photo.

When I added a hidden image directly underneath the h-card tag, IndieWebify was able to parse it.

The expectation is that no matter how far nested the u-photo or any property is, it should be parsed and picked up.You may see the current source HTML on my site.

This is a behaviour that is also mimicked by Indieweb Webring and a similar issue has been filed.
@MaybeThisIsRu MaybeThisIsRu mentioned this issue Sep 4, 2020
Open
@gRegorLove
Copy link
Member

The php-mf2 dependency is locked to quite an old version, v0.2.12. v0.4.0 fixed an issue where some h-* classes were being parsed as microformats2 when they shouldn't be. In your HTML there's class h-40 which the old parser is (incorrectly) parsing as a nested microformat inside the h-card.

Thanks for reporting this @hirusi. You can be assured that the u-photo in the nested divs is found correctly by modern parsers, so you don't have to keep the duplicate, hidden image currently. Once we update that dependency, indiewebify.me will show that nested photo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gRegorLove @MaybeThisIsRu