Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author linking fails between h-entry/u-author and external h-card/u-url #72

Open
kaushalmodi opened this issue Mar 26, 2018 · 3 comments
Open

Author linking fails between h-entry/u-author and external h-card/u-url #72

kaushalmodi opened this issue Mar 26, 2018 · 3 comments

Comments

@kaushalmodi
Copy link
kaushalmodi commented Mar 26, 2018 •
edited
Loading

Hello,

Here is an example page: https://scripter.co/hugo-leaf-and-branch-bundles/

Inside h-entry

<a href="https://scripter.co/" class="u-author">Kaushal Modi</a>

Inside h-card

<div class="h-card">
    <a class="p-name u-url" href="https://scripter.co/">Kaushal Modi</a>
    <!-- snip -->
</div>

The author linking is working as per:

But https://indiewebify.me/validate-h-entry/?url=https%3A%2F%2Fscripter.co%2Fhugo-leaf-and-branch-bundles%2F gives:

You’re marking up your post’s author as a string — add h-card to make it a full h-card!

image

Can this please be fixed?

\cc @aaronpk
@sknebel
Copy link
Member
sknebel commented Jul 5, 2018 •
edited
Loading

This is pretty much part of #6, and something that has come up a fair bit recently in this specific form.

Do we have a readymade authorship algorithm implementation in PHP? I guess XRay contains one, not sure if it can easily be used standalone?

@aaronpk
Copy link
Member
aaronpk commented Jul 5, 2018

XRay does implement I believe the full authorship algorithm. We could pull XRay in to this project. The only trick is that it won't show detailed debugging information about why it found the author or not, it just returns the author info when it finds it.

@aciccarello
Copy link
Contributor

I think this can be closed in favor of #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aaronpk @sknebel @kaushalmodi @aciccarello