Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix move global import in publisher sample #866

Merged
merged 3 commits into from
Feb 14, 2023
Merged

ci: fix move global import in publisher sample #866

merged 3 commits into from
Feb 14, 2023

Conversation

acocuzzo
Copy link
Contributor

Move global import to samples function to avoid confusion

@acocuzzo acocuzzo requested review from a team as code owners February 13, 2023 21:46
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 13, 2023
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Feb 13, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 13, 2023
@acocuzzo acocuzzo changed the title fix: move global import in publisher sample ci: fix move global import in publisher sample Feb 13, 2023
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2023
@acocuzzo acocuzzo merged commit 271a46d into googleapis:main Feb 14, 2023
@release-please release-please bot mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

@rsamborski rsamborski Awaiting requested review from rsamborski rsamborski is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acocuzzo @kamalaboulhosn @hongalex