Can't collect artifacts from a folder containing a "%" or ";" in its name #12466
Description
Issue Type
- Bug Report
Summary
I have a test checking that all special characters are correctly handled in my program. The program creates folders with special characters. In GoCD if an artifact wildcard pattern matches one of such folders containing a "%" or ";" in its name then uploading the artifacts fails.
Basic environment details
- Go Version:
23.5.0 (18179-7702b283accd1f90f014f0087aa2e9bd8baf4a97). - JAVA Version:
17.0.9 - OS:
Linux 5.15.0-88-generic
Steps to Reproduce
-
Create such a shell job:
mkdir %
touch %/test.log -
Create an artifact pattern **/*.log
-
Run the pipeline with this job.
Expected Results
%/test.log successfully uploaded to the artifact folder of the GoCD server.
Actual Results
Job log:
[go] Uploading artifacts from /var/lib/go-agent-3/pipelines/bug/%/test.log to /%
[go] Failed to upload /var/lib/go-agent-3/pipelines/bug/%/test.log
The same behaviour is observed with a ";". Interestingly, the error occurs only for folders, artifact files dir/%.log and dir/";".log are uploaded successfully.