-
Notifications
You must be signed in to change notification settings - Fork 320
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: geminabox/geminabox
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: geminabox/geminabox
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 6 files changed
- 2 contributors
Commits on Mar 28, 2021
-
Fixed. doesn't work on Ruby 3.0
`rss` gem is moved to bundled gem c.f. https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Configuration menu - View commit details
-
Copy full SHA for 44fcd81 - Browse repository at this point
Copy the full SHA 44fcd81View commit details -
Configuration menu - View commit details
-
Copy full SHA for a801a39 - Browse repository at this point
Copy the full SHA a801a39View commit details -
Fixed. test is failed on Ruby 3.0+
``` 1) Error: LargeGemListSpec#test_method: more than 5 versions of the same gem : ArgumentError: wrong number of arguments (given 2, expected 0..1) /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/rack_test/node.rb:67:in `click' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/rack_test/node.rb:131:in `call' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/rack_test/node.rb:131:in `click' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-mechanize-1.11.0/lib/capybara/mechanize/node.rb:12:in `click' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/node/element.rb:172:in `block in click' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/node/element.rb:597:in `block in perform_click_action' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/node/base.rb:83:in `synchronize' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/node/element.rb:597:in `perform_click_action' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/node/element.rb:171:in `click' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/node/actions.rb:42:in `click_link' /Users/sue445/workspace/github.com/geminabox/geminabox/vendor/bundle/ruby/3.0.0/gems/capybara-3.35.3/lib/capybara/session.rb:762:in `click_link' /Users/sue445/workspace/github.com/geminabox/geminabox/test/integration/web_interface/large_gem_list_test.rb:32:in `block in <class:LargeGemListSpec>' ``` c.f. phillbaker/capybara-mechanize#68 (cherry picked from commit 4fa2f7a)
Configuration menu - View commit details
-
Copy full SHA for 5fc5b14 - Browse repository at this point
Copy the full SHA 5fc5b14View commit details -
Latest master branch (will be next version) of capybara-mechanize is requires ruby 2.3.0+ phillbaker/capybara-mechanize@ec29688#diff-169a230d5998eabe69cc2134c7dbf5ac54f45bfce1c4752cf48ed96b73466526R9 c.f. https://travis-ci.org/github/geminabox/geminabox/jobs/761589443 (cherry picked from commit 76eb79e)
Configuration menu - View commit details
-
Copy full SHA for 84e9db9 - Browse repository at this point
Copy the full SHA 84e9db9View commit details -
Fixed
bundle install
error on Ruby 3.0rubygems 2.7.9 doesn't work on Ruby 3.0. So I use latest rubygems on Ruby 3.0 https://travis-ci.org/github/geminabox/geminabox/jobs/764702976 ``` Resolving dependencies... Using rake 13.0.3 Fetching public_suffix 4.0.6 /home/travis/.rvm/rubies/ruby-3.0.0/lib/ruby/site_ruby/3.0.0/bundler/shared_helpers.rb:35: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2. Bundler::GemspecError: Could not read gem at /home/travis/.rvm/gems/ruby-3.0.0/cache/public_suffix-4.0.6.gem. It may be corrupted. An error occurred while installing public_suffix (4.0.6), and Bundler cannot continue. Make sure that `gem install public_suffix -v '4.0.6' --source 'https://rubygems.org/'` succeeds before bundling. In Gemfile: capybara-mechanize was resolved to 1.11.0, which depends on capybara was resolved to 3.35.3, which depends on addressable was resolved to 2.7.0, which depends on public_suffix The command "eval bundle install --without development " failed 3 times. ```
Configuration menu - View commit details
-
Copy full SHA for 1d7147e - Browse repository at this point
Copy the full SHA 1d7147eView commit details -
Fixed deprecation warning for
Bundler.with_clean_env
``` [DEPRECATED] `Bundler.with_clean_env` has been deprecated in favor of `Bundler.with_unbundled_env`. If you instead want the environment before bundler was originally loaded, use `Bundler.with_original_env` (called at /Users/sue445/workspace/github.com/geminabox/geminabox/test/test_support/geminabox_test_case.rb:123) ```
Configuration menu - View commit details
-
Copy full SHA for b64f532 - Browse repository at this point
Copy the full SHA b64f532View commit details -
Configuration menu - View commit details
-
Copy full SHA for f183195 - Browse repository at this point
Copy the full SHA f183195View commit details
Commits on May 29, 2021
-
Merge pull request #340 from sue445/ruby_3.0
Fixed. doesn't work on Ruby 3.0
Configuration menu - View commit details
-
Copy full SHA for dbfcd54 - Browse repository at this point
Copy the full SHA dbfcd54View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc76c69 - Browse repository at this point
Copy the full SHA cc76c69View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.3.1...v1.4.0