Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format/ranges.h missing const qualifier on format member function #2754

Closed
andijcr opened this issue Feb 10, 2022 · 2 comments
Closed

format/ranges.h missing const qualifier on format member function #2754

andijcr opened this issue Feb 10, 2022 · 2 comments

Comments

@andijcr
Copy link
andijcr commented Feb 10, 2022 •
edited
Loading

fmt/include/fmt/ranges.h

Line 388 in ecd6022

auto format(U& range, FormatContext& ctx) -> decltype(ctx.out()) {

this member function could use const qualifier, maybe also constexpr.

I was getting this error, before adding const to my local copy
ranges.h:525:27: error: passing ‘std::__tuple_element_t<0, std::tuple<fmt::v8::formatter<std::array<unsigned char, 8>, char, void>, fmt::v8::formatter<long unsigned int, char, void> > >’ {aka ‘const fmt::v8::formatter<std::array<unsigned char, 8>, char, void>’} as ‘this’ argument discards qualifiers
@vitaut
Copy link
Contributor
vitaut commented Feb 10, 2022

Could you submit a PR?

@phprus phprus mentioned this issue Feb 10, 2022
Merged
@vitaut vitaut closed this as completed Feb 10, 2022
@andijcr
Copy link
Author
andijcr commented Feb 10, 2022

Thanks!

@WBurzynski WBurzynski mentioned this issue Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andijcr @vitaut