Upgrade sinatra dependency to 4.2.1 #18305
Draft
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mashhurs
commented
Oct 14, 2025
| mustermann (~> 3.0) | ||
| rack (>= 3.0.0, < 4) | ||
| rack-protection (= 4.1.1) | ||
| rack-protection (= 4.2.1) |
There was a problem hiding this comment.
It looks like rack-protection also aligns with sinatra version. I have compared with main Gemlock.file that other sub-dependencies like base64, logger, rack boundaries do not change (make sure we don't get big changes besides our intention).
💛 Build succeeded, but was flaky
Failed CI StepsHistory |
|
Somehow one of the PQ CIs (part-2-of-6) hung for more than hour, retried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Upgrades sinatra dependency to 4.2.1
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs