Fix existing row styles when using spliceRows #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm really not familiar with how styles work, but is this related to #722 @Siemienik ? |
Siemienik
reviewed
Feb 18, 2019
| @@ -330,6 +330,10 @@ Worksheet.prototype = { | |||
| rSrc = this._rows[i - 1]; | |||
| if (rSrc) { | |||
| this.getRow(i + nExpand).values = rSrc.values; | |||
| // eslint-disable-next-line no-loop-func | |||
| rSrc.eachCell({ includeEmpty: true }, function(cell, colNumber) { | |||
| this.getRow(i + nExpand).getCell(colNumber).style = cell.style; | |||
There was a problem hiding this comment.
@Siemienik do you think that would be necessary because the row that we get the style for each cell gets set to undefined anyway?
There was a problem hiding this comment.
I worry about case like this one #669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the style issues reported in #305 and #697 to copy over any existing styles already applied to rows. I have also included additional tests for this fix.