chore(server): Allow using background fibers for DEBUG OBJHIST #5933
+57
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
|
Tested it with (Remember that scheduler background fiber settings can be chagned at runtime as well) |
romange
reviewed
Oct 21, 2025
romange
reviewed
Oct 21, 2025
| config_registry.RegisterMutable("max_segment_to_consider"); | ||
| config_registry.RegisterMutable(" 8000 pipeline_squash"); | ||
| config_registry.RegisterMutable("lua_mem_gc_threshold"); | ||
| config_registry.RegisterMutable("background_debug_jobs"); |
There was a problem hiding this comment.
can you please add same support for "dfly expire" ? maybe rename background_debug_jobs to background_jobs ?
There was a problem hiding this comment.
DFLY EXPIRE is a transactional command. I can make it non-transactional and move the traversal to some common header, but I'd suggest to do so in a different PR
There was a problem hiding this comment.
we should make it non-transactional.
Co-authored-by: Roman Gershman <romange@gmail.com> Signed-off-by: Vladislav <vladislav.oleshko@gmail.com>
|
LGTM, make sure tests pass |
romange
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEBUG OBJHISTGetRunningTimeCycles-> Should make it safer to run it on busy datastores
I though of adding the same functionality to huffman compuations, but they're quite stateful/conditional, so it would've required more work 😞