Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Change git tagging pattern #579

Closed
iboB opened this issue Jan 8, 2022 · 4 comments
Closed

[meta] Change git tagging pattern #579

iboB opened this issue Jan 8, 2022 · 4 comments

Comments

@iboB
Copy link
Member
iboB commented Jan 8, 2022

git-based package managers and tools often expect the repo tags for versions to be in the form of the version number prepended with "v" (as in v1.2.3) and there is an unwritten "rule" in GitHub that this is preferred way to tag versions.

Using tags of this form will make the integration of doctest in such toolchains easier and make it more like many other GitHub projects.

@onqtam
Copy link
Member
onqtam commented Jan 10, 2022

Will change with the next release, thanks!

@onqtam onqtam closed this as completed Jan 10, 2022
@onqtam
Copy link
Member
onqtam commented Jan 10, 2022

https://github.com/doctest/doctest/releases/tag/v2.4.8

@YarikTH
Copy link
YarikTH commented Jan 13, 2022

It looks funny, because "nlohmann/json" had the opposite issue with Conan version ranges not working because of "v".
nlohmann/json#2409

@iboB
Copy link
Member Author
iboB commented Jan 13, 2022

as put by one of the commenters in the link:

IMHO it is conan's job to support v prefixes.

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants