hadolint: multiple fixes and adapt expected format #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac7fe46
to
180bb43
Compare
- Show hadolint rule number in vim gutter in addition to `ALEDetails` - Capture and show error in case of syntax errors - Add tests for error capture - Adapt existing tests fixes: dense-analysis#2333 fixes: dense-analysis#958
180bb43
to
faf60c1
Compare
|
@infokiller beat me to fixing the color output and input file name in #3680. But this commit still fixes the other issues like showing the code in the vim gutter and test coverage. |
|
@m-ildefons sorry I missed your PR. As I mentioned in the other one, there is now also json output which will make parsing much easier, but I'm not sure if it should be used since it can break ALE with older versions of hadolint that don't support it. |
|
No problem 😄 . Considering that switching to the json output basically involves writing the plugin and its tests from scratch, I don't think its worth the effort right now. This may change if there ever needs to be a fix done to this again. |
ddnomad
approved these changes
Jun 7, 2021
hsanson
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALEDetails39d22ad changed the file name, when reading from stdin from
/dev/stdinto
-. This broke integration with ALE.c00fc5c colorized the output to tty by default and added the flag
--no-colorto disable it again. This broke detecting issue severity.fixes: #2333
fixes: #958