Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The version of the package cannot be determined #376

Open
pjhavariotis opened this issue Jun 19, 2024 · 4 comments
Open

[BUG] The version of the package cannot be determined #376

pjhavariotis opened this issue Jun 19, 2024 · 4 comments
Assignees

Comments

@pjhavariotis
Copy link

After installing the latest package via winget, the version of the package cannot be determined (Version: Unknown)

What OS and Version?

Windows: Windows.Desktop v10.0.19045.4412

Description of issue

Please check the following issue for more info:
microsoft/winget-pkgs#158740

@dannagle
Copy link
Owner

I was able to recreate the error.

This package's version number cannot be determined. To upgrade it anyway, add the argument --include-unknown to your previous command.

Registry entries is a new winget requirement. By design, Packet Sender has never modified the registry. Not touching the registry makes the portable versions a lot easier to maintain and upgrade.

I can make an exception within the installer itself to try to keep the portable version fully portable. It'd have to be on the next version.

To be clear, the suggested --include-unknown bypass is working for you, correct?

@Trenly
Copy link
Trenly commented Jun 19, 2024

For additional context - portable installers (loose binaries) do not need to write anything to the Registry.

The version that is currently used for WinGet appears to be an inno installer - which should write to the registry by default as long as the AppVersion is set in the inno setup file
https://jrsoftware.org/ishelp/index.php?topic=setup_appversion

@pjhavariotis
Copy link
Author

I was able to recreate the error.

This package's version number cannot be determined. To upgrade it anyway, add the argument --include-unknown to your previous command.

Registry entries is a new winget requirement. By design, Packet Sender has never modified the registry. Not touching the registry makes the portable versions a lot easier to maintain and upgrade.

I can make an exception within the installer itself to try to keep the portable version fully portable. It'd have to be on the next version.

To be clear, the suggested --include-unknown bypass is working for you, correct?

Correct. However, it would be nice to follow the winget requirements.

@dannagle
Copy link
Owner

This is now fixed in the development branch. The next release will require one more --include-unknown, and then it should work as expected after that.

I'm leaving this ticket open as a reminder to doublecheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants