Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected emoji is inserted into all open chat boxes. #2868

Closed
SilverYoCha opened this issue Apr 4, 2022 · 0 comments
Closed

Selected emoji is inserted into all open chat boxes. #2868

SilverYoCha opened this issue Apr 4, 2022 · 0 comments

Comments

@SilverYoCha
Copy link
Contributor
SilverYoCha commented Apr 4, 2022

When several chat boxes are open, selected emoji is inserted into all of them.

To Reproduce

  1. Open several chat boxes
  2. Select an emoji from one of them
  3. Selected emoji is inserted into each of all open ones

Expected behavior
Selected emoji should have been inserted only into the chat box from which it has been selected.

Environment:

  • Desktop
  • Browser: all
  • Converse.js version 9.1.0

Additional context
I think there is a link with closed PR #2841.
I did surely not check this super basic use case when @jcbrand asked me to verify the emoji feature behavior after some refactoring.
I found locally a way to fix the issue, but according the minding behind the last emoji refactoring, I'm not sure that is a good one (SilverYoCha#2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants