Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulling image should not request auth tokens twice #1005

Closed
tonistiigi opened this issue Jun 14, 2017 · 3 comments · Fixed by #2690
Closed

pulling image should not request auth tokens twice #1005

tonistiigi opened this issue Jun 14, 2017 · 3 comments · Fixed by #2690
Milestone

Comments

@tonistiigi
Copy link
Member

Currently Resolver and Fetcher can not share the auth information meaning that they both need to do separate requests to fetch the tokens and retry.

@dmcgowan
Copy link
Member

Yes, we need to fix this. When we added the push code the fetcher was separated out and created different instance. We could have the resolver cache the base instance created to be used when the fetcher is created, it is kind of a weird pattern though. Alternatively could create a token cache shared almost everything created through the resolver.

@stevvooe
Copy link
Member

These two processes need to remain separate. Ideally, they could use the same token, but it is extremely important that resolution and fetching of content remain decoupled.

@crosbymichael crosbymichael modified the milestone: containerd beta Jul 10, 2017
@crosbymichael
Copy link
Member
crosbymichael commented Aug 24, 2017

Are we going to resolve this or is this a wont-fix? @dmcgowan

@crosbymichael crosbymichael modified the milestones: containerd beta, containerd 1.0.0 Sep 6, 2017
@dmcgowan dmcgowan modified the milestone: containerd 1.0.0 Sep 6, 2017
@dmcgowan dmcgowan modified the milestones: 1.0.0, 1.0.1 Dec 2, 2017
@stevvooe stevvooe modified the milestones: 1.0.1, 1.0.2 Jan 11, 2018
@stevvooe stevvooe modified the milestones: 1.0.2, 1.2, 1.1 Jan 25, 2018
@dmcgowan dmcgowan modified the milestones: 1.1, 1.2 Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants