-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulling image should not request auth tokens twice #1005
Comments
Yes, we need to fix this. When we added the push code the fetcher was separated out and created different instance. We could have the resolver cache the base instance created to be used when the fetcher is created, it is kind of a weird pattern though. Alternatively could create a token cache shared almost everything created through the resolver. |
These two processes need to remain separate. Ideally, they could use the same token, but it is extremely important that resolution and fetching of content remain decoupled. |
Are we going to resolve this or is this a wont-fix? @dmcgowan |
Currently
Resolver
andFetcher
can not share the auth information meaning that they both need to do separate requests to fetch the tokens and retry.The text was updated successfully, but these errors were encountered: